New Script: calibre-server #960
Draft
+168
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tag case, and add newline in success message
github-actions
bot
added
new script
michelroegl-brunner
requested changes
Dec 21, 2024
| update_os | ||
|
|
||
| msg_info "Installing Dependencies" | ||
| $STD apt-get install -y imagemagick xvfb libxcomposite1 |
There was a problem hiding this comment.
Suggested change
| $STD apt-get install -y imagemagick xvfb libxcomposite1 | |
| $STD apt-get install -y \ | |
| sudo \ | |
| curl \ | |
| mc \ | |
| imagemagick \ | |
| xvfb \ | |
| libxcomposite1 |
| msg_info "Installing Calibre (latest)" | ||
| # If your container runs as root, you generally do not need to prefix with `sudo`. | ||
| # The official Calibre instructions: | ||
| wget -nv -O- https://download.calibre-ebook.com/linux-installer.sh | sh /dev/stdin |
There was a problem hiding this comment.
Before Downloading, can you get the Version number somehow? Just so you can check during the update that it is needed. And is this operation truly silent?
| # Potentially re-run the official calibre script to ensure most recent version | ||
| # to keep logic consistent with how other scripts handle updates. | ||
| msg_info "Updating Calibre (latest)" | ||
| wget -nv -O- https://download.calibre-ebook.com/linux-installer.sh | sh /dev/stdin &>/dev/null |
There was a problem hiding this comment.
If possible check if there is a newer version wich needs to be installed. Have a look at the snipeit.sh file for reference.
Comment on lines
+38
to
+41
| { | ||
| "text": "Use 'calibredb add' from the calibre user or run 'xvfb-run calibredb add ...' if you need to add books while the server is running.", | ||
| "type": "info" | ||
| } |
There was a problem hiding this comment.
Remove and write a guide in the disscusion section.
| "documentation": null, | ||
| "website": "https://calibre-ebook.com", | ||
| "logo": "https://calibre-ebook.com/resources/icons/calibre_icon.png", | ||
| "description": "Calibre content server is usedto manage and serve eBooks over the network.", |
There was a problem hiding this comment.
Suggested change
| "description": "Calibre content server is usedto manage and serve eBooks over the network.", | |
| "description": "Calibre content server is used to manage and serve eBooks over the network.", |
| chown -R calibre:calibre /opt/calibre | ||
| msg_ok "Created calibre user & directories" | ||
|
|
||
| msg_info "Creating systemd service" |
There was a problem hiding this comment.
Suggested change
| msg_info "Creating systemd service" | |
| msg_info "Creating Service" |
Comment on lines
+24
to
+30
| msg_ok "Installed Calibre" | ||
|
|
||
| msg_info "Creating calibre system user & directories" | ||
| useradd -c "Calibre Server" -d /opt/calibre -s /bin/bash -m calibre | ||
| mkdir -p /opt/calibre/calibre-library | ||
| chown -R calibre:calibre /opt/calibre | ||
| msg_ok "Created calibre user & directories" |
There was a problem hiding this comment.
Suggested change
| msg_ok "Installed Calibre" | |
| msg_info "Creating calibre system user & directories" | |
| useradd -c "Calibre Server" -d /opt/calibre -s /bin/bash -m calibre | |
| mkdir -p /opt/calibre/calibre-library | |
| chown -R calibre:calibre /opt/calibre | |
| msg_ok "Created calibre user & directories" | |
| useradd -c "Calibre Server" -d /opt/calibre -s /bin/bash -m calibre | |
| mkdir -p /opt/calibre/calibre-library | |
| chown -R calibre:calibre /opt/calibre | |
| msg_ok "Installed Calibre" |
| $STD apt-get install -y imagemagick xvfb libxcomposite1 | ||
| msg_ok "Installed Dependencies" | ||
|
|
||
| msg_info "Installing Calibre (latest)" |
There was a problem hiding this comment.
Suggested change
| msg_info "Installing Calibre (latest)" | |
| msg_info "Installing Calibre" |
|
hey @michelroegl-brunner , thank you for taking a look through my PR. I had actually set this up as a draft and wasn't expecting anyone to review. I will update with your recommended changes when I get the chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Create a new script that adds calibre-server as an LXC
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.